Difference between revisions of "Revert Policy"

From Openembedded.org
Jump to: navigation, search
(add revert policy)
 
 
(4 intermediate revisions by 4 users not shown)
Line 1: Line 1:
A revert is a special type of commit which undos another commit. This is our policy for reverts:
+
Reverting someone elses work can be a great source of friction in OE. As such, these need to be handled carefully, preferable on technical grounds rather than personal ones. Some cases are clear, e.g. if the orignal patch author requests a revert then this should generally be accepted.
  
# Reverting your own commit is never a problem. This can be necessary to fix an important bug introduced by your commit or something you accidently committed.
+
Now that OE uses layers, the situation is relatively clear since each layer has clear and documented maintainership and it is up to the layer maintainership to make decisions on whether code should be reverted.  
# Reverting a commit of another user is a problem. If you wish to do so, please post a request for comments to the mailing list and wait until you either get the ACK of the committer or two ACKs non-committer ACKs. Do _not_ revert before getting any of those ACKs.
+
 
 +
In cases where there is any doubt, the OE TSC has final decision and authority.
  
 
[[Category:Policy]]
 
[[Category:Policy]]
 +
[[Category:Quality Assurance]]

Latest revision as of 10:13, 7 November 2012

Reverting someone elses work can be a great source of friction in OE. As such, these need to be handled carefully, preferable on technical grounds rather than personal ones. Some cases are clear, e.g. if the orignal patch author requests a revert then this should generally be accepted.

Now that OE uses layers, the situation is relatively clear since each layer has clear and documented maintainership and it is up to the layer maintainership to make decisions on whether code should be reverted.

In cases where there is any doubt, the OE TSC has final decision and authority.