[bitbake-devel] Conditional assignment broken

[Chris Larson]

On Fri, Aug 12, 2011 at 4:42 PM, Joshua Lock <josh at linux.intel.com> wrote:
> On Fri, 2011-08-12 at 16:32 -0700, Chris Larson wrote:
>> On Fri, Aug 12, 2011 at 4:29 PM, Joshua Lock <josh at linux.intel.com> wrote:
>> > On Sat, 2011-08-13 at 06:50 +0800, James Limbouris wrote:
>> >> Hi,
>> >>
>> >>  Commit 21c21fcc5871e81d8d497b6baed605cdd74c4571 breaks conditional assignment
>> >>  in all conf files. Previously, the environment was copied from a
>> >> cleaned up os environment.
>> >>  After the commit, a pristine environment is available in
>> >> data['_data'], and will be copied to
>> >>  data[] on conditional assignment, defying BB_ENV_EXTRAWHITE.
>> >> Variables not conditionally
>> >>  assigned will still be available from data['_data'], also in defiance
>> >> of BB_ENV_EXTRAWHITE.
>> >>
>> >>  To verify, simply:
>> >>
>> >>  export RANDOMENV=42
>> >>  bitbake -e | grep RANDOMENV
>> >
>> > Thanks for the report James, and apologies for the breakage. I'll try
>> > and get a fix submitted and merged asap.
>> >
>> > I'm now wondering if we want the pristine environment, or the cleaned
>> > environment, saved.
>>
>> For things like devshell, I think it would be nice to retain a copy of
>> the original, unmodified environment.
>
> Agreed, that was one of the intended consumers. I guess I need to drink
> more coffee and figure out the *right* fix then...

You could pass the key list from the filtered env along with the
unfiltered dict to inheritFromOS, rather than using all the keys from
the unfiltered env, I would think.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics