[bitbake-devel] [PATCH 01/10] command.py: Modify needcache value for certain functions

[Joshua Lock]

On 11/12/11 18:20, Dongxiao Xu wrote:
> for findConfigFiels() and findFilesMatchingInDir() functions, they
> don't need to parse all the bb files, thus setting the needcache
> value to be False.
> 
> Signed-off-by: Dongxiao Xu <dongxiao.xu at intel.com>

If we can't rely on event_data to be consistent/up-to-date do we need to
keep it around? The comment around its creation implies we want/need the
copy of data.

This feels like we're working around on issue rather than fixing one.

Joshua

> ---
>  lib/bb/command.py |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/bb/command.py b/lib/bb/command.py
> index 83907f6..5dec6a9 100644
> --- a/lib/bb/command.py
> +++ b/lib/bb/command.py
> @@ -241,7 +241,7 @@ class CommandsAsync:
>  
>          command.cooker.findConfigFiles(varname)
>          command.finishAsyncCommand()
> -    findConfigFiles.needcache = True
> +    findConfigFiles.needcache = False
>  
>      def findFilesMatchingInDir(self, command, params):
>          """
> @@ -253,7 +253,7 @@ class CommandsAsync:
>  
>          command.cooker.findFilesMatchingInDir(pattern, directory)
>          command.finishAsyncCommand()
> -    findFilesMatchingInDir.needcache = True
> +    findFilesMatchingInDir.needcache = False
>  
>      def findConfigFilePath(self, command, params):
>          """

-- 
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre