[bitbake-devel] [PATCH 03/10] cooker: user bb.configuration.data to inject events

[Joshua Lock]

On 11/12/11 18:20, Dongxiao Xu wrote:
> For buildTargets function, we use bb.configuration.data as parameter
> to inject events, since in hob environment, some variables are
> modified dynamically and bb.configuration.event_data may out of date.
> 
> Signed-off-by: Dongxiao Xu <dongxiao.xu at intel.com>

I discussed this patch with Dongxiao when he worked on it so it has my ACK.

Signed-off-by: Joshua Lock <josh at linux.intel.com>

> ---
>  lib/bb/cooker.py |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/bb/cooker.py b/lib/bb/cooker.py
> index 2c02e28..6ddb38e 100644
> --- a/lib/bb/cooker.py
> +++ b/lib/bb/cooker.py
> @@ -1085,7 +1085,7 @@ class BBCooker:
>                  return False
>  
>              if not retval:
> -                bb.event.fire(bb.event.BuildCompleted(buildname, targets, failures), self.configuration.event_data)
> +                bb.event.fire(bb.event.BuildCompleted(buildname, targets, failures), self.configuration.data)
>                  self.command.finishAsyncCommand()
>                  return False
>              if retval is True:
> @@ -1095,7 +1095,7 @@ class BBCooker:
>          self.buildSetVars()
>  
>          buildname = self.configuration.data.getVar("BUILDNAME")
> -        bb.event.fire(bb.event.BuildStarted(buildname, targets), self.configuration.event_data)
> +        bb.event.fire(bb.event.BuildStarted(buildname, targets), self.configuration.data)
>  
>          localdata = data.createCopy(self.configuration.data)
>          bb.data.update_data(localdata)

-- 
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre