[bitbake-devel] [PATCH 1/1] die if a .bbappend file matches no existing .bb recipe

[Cui, Dexuan]

Richard Purdie wrote:
> On Mon, 2011-06-27 at 14:06 +0100, Paul Eggleton wrote:
>> Martin Jansa wrote:
>>> Imagine the case when you enable some layer managed by someone else
>>> (lets call it LS) and you're using different oe-core revision, maybe
>>> current HEAD and that LS wasn't updated for that or vice versa
>>> you're using some oe-core release version and you want to reuse
>>> some recipes from LS in current version. 
>>> 
>>> I think that big fat warning that some .bbappends does not match
>>> should be enough to decide if it's fatal for me (and I'll kill that
>>> build) or that's fine (when I'm not interested in those .bbappends
>>> from LS and I'm using only some other .bb files from LS).
>>> 
>>> If we make it fatal then I would be forced to remove unmatched
>>> .bbappends from LS before build which can be difficult to share
>>> (unless I create own LS branch and use it in my distro).
>> 
>> I see what you're saying, but I'm worried about the visiblity (or
>> lack thereof) of these warnings.  If you start a build, go off
>> somewhere and come back when the build is part way through or
>> finished, you may be oblivious to the fact that there might be a
>> serious problem - i.e. the customisations you expected to be applied
>> haven't been. 
>> 
>> It all depends on whether the bbappends are supposed to apply to
>> recipes that are to be used in the build you're doing - if they are,
>> then IMHO the error should be fatal. I wonder if it's practical to
>> make it work that way...? 
> 
> I think it should be fatal by default but have some kind of variable
> we can set to disable it...

Sorry -- what's the conclusion?
Keeping the v2 patch(http://git.pokylinux.org/cgit/cgit.cgi/poky-contrib/commit/?h=dcui/bb-v2&id=2a520959f71ec2cd80ed2088bfcf082631161a1a), or changing bb.error() to bb.warn()?

Thanks,
-- Dexuan