[bitbake-devel] [PATCH] codeparser: accept a name for better messages

[Chris Larson]

On Fri, Oct 28, 2011 at 6:57 PM, Christopher Larson <kergoth at gmail.com> wrote:
> From: Christopher Larson <chris_larson at mentor.com>
>
> - If a name is passed to the parser, prepend the messages with "while
>  parsing <name>:". This gives a bit more context.
> - Tweak the warning messages slightly (they had to be altered anyway to
>  inject the variable being parsed).
>
> Before:
>  DEBUG: Warning: in call to 'bb.data.getVar': argument ''%s' % var' is \
>         not a literal
>
> After:
>  DEBUG: while parsing emit_pkgdata, in call of bb.data.getVar, argument \
>         ''%s' % var' is not a string literal
>
> Signed-off-by: Christopher Larson <chris_larson at mentor.com>


Note: applies on top of the previous series. Does this message wording
seem sane to people, or would you prefer it remain more like the
previous one? I rather like the new sentence form. Also, 'Warning'
could unnecessarily scare users looking back at logs.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics