[bitbake-devel] [PATCH 09/10] Hob: Change base image to "Create your own image" if customized

[Wang, Shane]

Dongxiao suggested another solution. If any recipe is removed from or added into the list.
The base image could be changed into e.g. "core-image-minimal *" or "core-image-minimal-changed" to indicates the set is based on core-image-minimal.
Technically, what we want is to change the base image name, we can't reuse "core-image-minimal".

--
Shane

Barros Pena, Belen wrote on 2012-04-06:

> 
> On 06/04/2012 04:45, "Xu, Dongxiao" <dongxiao.xu at intel.com> wrote:
> 
>> On Wed, 2012-04-04 at 23:21 +0800, Barros Pena, Belen wrote:
>>> Thanks for explaining, Shane. I now understand why you are doing it, but
>>> people using Hob will not have the benefit of your explanation. They
>>> will
>>> just see they selected a base image, made a small change to that base
>>> image and when they go back to the Image configuration screen, Hob has
>>> changed the base image they selected of its own accord.
>> 
>> Though the base image is changed to "Create your own image", however all
>> the contents in the base image (except those customized) are still
>> there. If user changes recipes/packages, actually they are trying to
>> create their own image not a base image.
> 
> I don't think so, Dongxiao: for BitBake, the user is trying to create
> their own image. For me (Hob user) I am trying to create
> core-image-minimal without recipe x.
> 
> But I see we are going to get into one of those circular arguments. We
> need evidence that this is a problem. Until I can provide you with that, I
> accept the easiest way to handle this is changing the user selection to
> "Create your own image" when customisation happens.
> 
> What a hard life ;)
> 
>> 
>>> 
>>> Could the template have some "hidden" information indicating if a base
>>> image has been customised and therefore the default contents of the base
>>> image should be ignored and replaced with the remembered recipes and
>>> packages? This way the template would still work, but Hob users will
>>> still
>>> see their selected base image.
>> 
>> Base image is also a recipe, so we could not ignore its related recipes,
>> unless we switch to a new one whose dependency recipes/packages are
>> None. Otherwise, it will change the core base of the Hob logic.
>> 
>> Thanks,
>> Dongxiao
>> 
>>> 
>>> Belen
>>> 
>>> On 04/04/2012 13:58, "Wang, Shane" <shane.wang at intel.com> wrote:
>>> 
>>>> Barros Pena, Belen wrote on 2012-04-03:
>>>> 
>>>>> From the design side of things, I am not sure this is a good idea.
>>>>> I've explicitly selected 'base image x'. If I then customise it, I
>>>>> still think I am working on 'base image x'. I might not understand
>>>>> why my selection of base image has been changed automatically. In
>>>>> general, it is not a good idea to have software that changes things
>>>>> I do of its own accord. Such behaviours undermine the sense of
>>>>> control users should have when interacting with software.
>>>>> 
>>>>> Cheers
>>>>> 
>>>>> Belen
>>>>> 
>>>> 
>>>> What we want is to change the item in the base image combo. The
>>>> target image is still based on the base image the user selected plus
>>>> delta. We have the strict definition for the predefined base images.
>>>> For instance, sato includes 300 recipes. An image including 299
>>>> recipes is not called sato but your own image (say, sato-minus)
>>>> 
>>>> The reason why we do that is because for templates, we will remember
>>>> the item in the image combo as the base image in some bb file, and we
>>>> also remember what we selected for the recipes and the packages.
>>>> However, the base image covers all of them by default and because of
>>>> that, bitbake can't recognize the delta and will include all (300
>>>> recipes), which causes the wrong behavior.
>>>> 
>>>> --
>>>> Shane
>>> 
>> 
>>