[bitbake-devel] [PATCH 1/3] event.py: Add SanityCheck and SanityCheckPassed events

[Chris Larson]

On Tue, Apr 24, 2012 at 6:26 PM, Chris Larson <clarson at kergoth.com> wrote:
> On Tue, Apr 24, 2012 at 1:16 AM, Dongxiao Xu <dongxiao.xu at intel.com> wrote:
>> Signed-off-by: Dongxiao Xu <dongxiao.xu at intel.com>
>> ---
>>  lib/bb/event.py |   10 ++++++++++
>>  1 files changed, 10 insertions(+), 0 deletions(-)
>>
>> diff --git a/lib/bb/event.py b/lib/bb/event.py
>> index bbece58..f3fb521 100644
>> --- a/lib/bb/event.py
>> +++ b/lib/bb/event.py
>> @@ -517,3 +517,13 @@ class PackageInfo(Event):
>>     def __init__(self, pkginfolist):
>>         Event.__init__(self)
>>         self._pkginfolist = pkginfolist
>> +
>> +class SanityCheck(Event):
>> +    """
>> +    Event to issue sanity check
>> +    """
>> +
>> +class SanityCheckPassed(Event):
>> +    """
>> +    Event to indicate sanity check is passed
>> +    """
>
> Sanity checking is not part of bitbake, nor does it belong there. I'd
> say to find another way to do this.

Erm, ignore this, I was obviously mistaken. I had no idea any of this
code existed. It does seem pretty questionable, still. 'sanity check'
is extremely vague, and unclear about what it does, and further, the
terminology overlaps with the various checks in the metadata. At a
minimum I'd think we should improve this naming.
-- 
Christopher Larson