[bitbake-devel] [PATCH 1/1] bitbake.conf: add BB_STAMPS_DIR for constructing STAMP

[Richard Purdie]

On Wed, 2012-08-15 at 21:49 +0800, Robert Yang wrote:
> 
> On 08/15/2012 09:42 PM, Richard Purdie wrote:
> > On Fri, 2012-08-10 at 10:02 +0800, Robert Yang wrote:
> >> Add BB_STAMPS_DIR for constructing STAMP, the defination of STAMP
> >> before:
> >>
> >> STAMP = "${TMPDIR}/stamps/${MULTIMACH_TARGET_SYS}/${PF}
> >>
> >> We can only change the TMPDIR if we want to change the STAMP's location,
> >> but the cache would be regenerated if TMPDIR changed, so add
> >> BB_STAMPS_DIR for constructing it, and add it to the BB_ENV_EXTRAWHITE,
> >> this is very usefull for the "bitbake -S", since then it can be run by:
> >>
> >> BB_STAMPS_DIR=<path> bitbake -S <recipe>
> >>
> >> which will avoid putting the stamps to ${TMPDIR}/stamps.
> >>
> >> BTW, break the too long BB_ENV_EXTRAWHITE into several lines.
> >>
> >> [YOCTO #1659]
> >>
> >> Signed-off-by: Robert Yang <liezhi.yang at windriver.com>
> >> ---
> >>   meta/conf/bitbake.conf       | 3 ++-
> >>   scripts/oe-buildenv-internal | 5 ++++-
> >>   2 files changed, 6 insertions(+), 2 deletions(-)
> >
> > BB_ is a prefix for variables bitbake specifically uses for
> > configuration. It doesn't fit in this context since its metadata defined
> > and doesn't actually influence or is used by bitbake itself.
> >
> > We therefore need to use a different name for this.
> >
> 
> Thanks, how about "STAMPS_DIR" ? And can we put the bitbake-whatchanged
> to bitbake/bin or bitbake/contrib as Chris Larson worried about ?

He's right, it depends on the metadata and therefore shouldn't really be
in bitbake. It could go into scripts/ in oe-core.

Cheers,

Richard