[bitbake-devel] what means "this=ignored" in the context of SRC_URI/patch?

[Robert P. J. Day]

On Sun, 30 Dec 2012, Chris Larson wrote:

> On Sun, Dec 30, 2012 at 3:45 PM, Robert P. J. Day <rpjday at crashcourse.ca> wrote:
>       i've poked around and checked logs and i have no idea what
>       "this=ignored" means.  is it an earlier equivalent of "apply=no"?
>       i've never run across it being used anywhere.
>
>
> Never heard of such a thing, personally.

  ok, so that can be safely removed from the bitbake manual.

>         and while we're on the topic, i'm assuming adding "apply=yes" is
>       utterly redundant, yes?  even though there are a bunch of them
>       sprinkled throughout some recipes in oe-core.
>
> As has been mentioned before, apply=yes is only implicit and
> automatic when the filename ends in .{patch,diff}{,.gz}.

  while i'm not a python expert, i'm not convinced.  here's the code
from patch.bbclass:

def patch_path(url, fetch, workdir):
    """Return the local path of a patch, or None if this isn't a patch"""

    local = fetch.localpath(url)
    base, ext = os.path.splitext(os.path.basename(local))
    if ext in ('.gz', '.bz2', '.Z'):
        local = os.path.join(workdir, base)
        ext = os.path.splitext(base)[1]

    urldata = fetch.ud[url]
    if "apply" in urldata.parm:
        apply = oe.types.boolean(urldata.parm["apply"])
        if not apply:
            return
    elif ext not in (".diff", ".patch"):
        return
    ... snip ...

i notice that the value of "apply" is tested *before* the final test
for a valid patch suffix of {.patch,.diff}, which leaves open the
possibility of something weird or obscure happening there?  i have no
idea what that might be, i'm just observing the order of those tests.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================