[bitbake-devel] [PATCH 1/2] bitbake: fix parse errors not being reported

[Chris Larson]

On Thu, Feb 23, 2012 at 10:23 AM, Paul Eggleton
<paul.eggleton at linux.intel.com> wrote:
> On Thursday 23 February 2012 09:14:16 Chris Larson wrote:
>> <paul.eggleton at linux.intel.com> wrote:
>> >         except Exception as exc:
>> > -            etype, value, tb = sys.exc_info()
>> > -            logger.error('Unable to parse %s', value.recipe,
>> > -                         exc_info=(etype, value, exc.traceback))
>> > +            logger.error('Error during parsing %s: %s\n%s' % (exc.recipe,
>> > str(exc), ''.join(bb.exceptions.format_extracted(exc.traceback,
>> > limit=5))))
>> This seems odd to me. Is the UI not displaying the traceback when sent
>> to it via the exc_info? Half the point of coming up with the new
>> traceback format which is pickleable was to allow us to do exception
>> formatting in the UI.
>
> Actually that's odd, I could have sworn when I tried this it broke, but it
> seems to be doing the right thing now. Will send a v2 reverting this part.
>
> Presumably you are happy with the rest of it?

Yeah, looks fine to me, nice work.
-- 
Christopher Larson