[bitbake-devel] [PATCH 0/1][PULL] Hob2: A new implementation for Human Oriented Builder

[Wang, Shane]

Joshua Lock wrote on 2012-02-28:

> 
> 
>>> It's also worth noting that the visual style 'leaks' in the Settings
>>> dialogue and I see standard Gtk light-bulb info icons rather than the
>>> steely i displayed on the main page.
>> In the settings dialog, we didn't make any specific icon for tool tip.
>> On Ubuntu, it is a "i". On Fedora 16, it becomes a light-bulb. I am thinking
> how to make it?
> 
> That's because Ubuntu and Fedora use different stock themes. I think it
> makes sense to use the i graphic from the visual design wherever you're
> currently using gtk.STOCK_INFO.
OK, will have a try.

> 
>>> Further, there are still hard-coded colour values. Are these issues on
>>> the "to fix later" list?
>> Do you mean the green progress bar and others? For the progress bar,
> Jessica has a comment that she doesn't want see orange bar which is the
> default on Ubuntu but want to see a green one which is consistent with the
> running color in the build details.
>> For some buttons like "Just bake", we try to make it look the same as
>> Belen's video. Are you suggesting to set them default?
> 
> I am, but I guess the design team needs to have the final say here. I
> think Belen agreed with me in principle that we should use the colours
> from the users theme to start and iterate from there. On my Fedora
> machine green progress bars and orange buttons look rather out of place
> in a software ecosystem which has a fairly consistent look and feel
> between applications. However I care less about the colours than I do
> about the button order, per my submitted patches.
I also agree to use the default colors set by the OS.

>>> There's at least one instance of commented out code (a signal handler
>>> connection in builder.py) - we can probably drop those, right?
>> Do you mean to drop the handler instance in builder.py?
>> If so, how could the builder call the handler's functions?
> 
> There's a commented out line which would connect to a signal handler
> where it not commented out at line 201 of builder.py:
> http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/bitbake/lib/bb/ui/cru
> mbs/b uilder.py#n201
> 
> We can probably delete that, right?
My fault, my fault, when did it come there;-)

>>> Setting the size and position of windows on each launch (as in
>>> builder.py) is generally considered to be hostile to users - it should
>>> be sufficient to start with a sane default size and then as the UI
>>> allows the user to resize it we should remember the size for the next
>>> launch.
>> OK. But sometimes we should consider the screen dimension. For instance
> the builder, the main window, I bet on a smaller screen (say, 800X600) the
> visual components will look ugly. How can I address the problem? For the
> position of the window, I agree.
> 
> I don't think that telling people their resolution is too low is
> especially helpful here. They can probably see that the GUI doesn't fit.
> 
> I don't know anyone that runs their system with a lower than supported
> resolution, so telling them about something they can't fix doesn't help
> them. It just adds insult to injury, so to speak.

Understand.

--
Shane