[bitbake-devel] [PATCH 00/32] Hob related fixes

[Joshua Lock]

Hi,

On 29/02/12 06:11, Shane Wang wrote:
> The following patches are going to fix the following problems:
>
> * Enable HobNotebook to make notebook more like the design video;
> * Improve and enhance the GUI;
> * Rebase the patches Josh has sent out before with the title "Hob tweaks";
> * Address some tricky issues we found in the bitbake;
> * Revise Hob according to the comments on the previous patch set;
> * Fix some bugs we found when testing Hob;
> * and some temporary walkarounds we have to find a way to solve in Hob or in the bitbake later.
>
> The following changes since commit 927bec5f72230be4f2452d9ef5a747b2c00cb781:
>
>    bitbake.conf: Create a new filter variable BB_HASHCONFIG_WHITELIST (2012-02-27 20:10:41 +0000)

This is a pretty decent series. I'd appreciate smaller ones in future as 
they're easier to review.

I've tried to comment on each patch with SOB's for the ones that I'm OK 
with and comments for the rest.

One thing I did notice whilst reviewing this series is that there's a 
lot of this anti-pattern in the hob 2 code:
	for i in range(len(mylist)):
rather than:
	for item in list:

Can we make an effort to tidy those up?

Cheers,
Joshua
-- 
Joshua Lock
         Yocto Project "Johannes factotum"
         Intel Open Source Technology Centre