[bitbake-devel] Paul Eggleton : bitbake-layers: close files in apply_append()

Chris Larson clarson at kergoth.com
Tue Jan 10 17:41:49 UTC 2012


On Tue, Jan 10, 2012 at 10:49 AM,  <git at git.openembedded.org> wrote:
> Module: bitbake.git
> Branch: master
> Commit: 470a160813ce6cf04f83258d46ded5c2ab8bc520
> URL:    http://git.openembedded.org/?p=bitbake.git&a=commit;h=470a160813ce6cf04f83258d46ded5c2ab8bc520
>
> Author: Paul Eggleton <paul.eggleton at linux.intel.com>
> Date:   Sun Jan  8 12:06:51 2012 +0000
>
> bitbake-layers: close files in apply_append()
>
> It's recommended practice to close files when finished with them and the
> code in this function was not doing this.
>
> Signed-off-by: Paul Eggleton <paul.eggleton at linux.intel.com>
> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

Given we require 2.6, fyi, you could use the context manager.
-- 
Christopher Larson




More information about the bitbake-devel mailing list