[bitbake-devel] [PATCH] bitbake/fetch2: add support for wrapper command

[McClintock Matthew-B29882]

On Fri, Jan 13, 2012 at 2:44 AM, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
> On Thu, 2012-01-12 at 17:09 -0600, Matthew McClintock wrote:
>> cc: bitbake-devel at lists.openembedded.org
>> Signed-off-by: Matthew McClintock <msm at freescale.com>
>> ---
>>  lib/bb/fetch2/__init__.py |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/lib/bb/fetch2/__init__.py b/lib/bb/fetch2/__init__.py
>> index 3af56e5..1d7d5c7 100644
>> --- a/lib/bb/fetch2/__init__.py
>> +++ b/lib/bb/fetch2/__init__.py
>> @@ -389,6 +389,8 @@ def runfetchcmd(cmd, d, quiet = False, cleanup = []):
>>      Optionally remove the files/directories listed in cleanup upon failure
>>      """
>>
>> +    cmd = "%s %s" % (bb.data.getVar("BB_FETCH_WRAPPER", d, True), cmd)
>> +
>>      # Need to export PATH as binary could be in metadata paths
>>      # rather than host provided
>>      # Also include some other variables.
>
> Er, this is going to break for anyone who doesn't have BB_FETCH_WRAPPER
> set. It would be nice to document why you require this in the commit
> message (I can guess). Since I'm rejecting this patch, can the next one
> document the new variable in the fetcher section of bitbake manual too
> please? :)

Sorry, was looking for feedback too - I think I need to do:

cmd = "%s %s" % (bb.data.getVar("BB_FETCH_WRAPPER", d, True) or "", cmd)

I wrote a small blurb about why it was needed on the patch to oe-core,
we are trying to do CVS or a SOCKS5 proxy that has authentication (the
proxy) - I didn't see another way around this...

-M