[bitbake-devel] [PATCH 1/1] hob2: add elf to hcc supported image types
Richard Purdie
richard.purdie at linuxfoundation.org
Tue Jul 17 09:52:57 UTC 2012
On Tue, 2012-07-17 at 14:58 +0800, Kang Kai wrote:
> [Yocto #2709]
>
> OE Core Commit c9b01af84b64edba056f959c349895e0698324e6 add elf image
> type. This will cause hob build image failed.
> Add elf to hcc supoorted image types to fix this issue.
>
> Signed-off-by: Kang Kai <kai.kang at windriver.com>
> ---
> bitbake/lib/bb/ui/crumbs/hobwidget.py | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/bitbake/lib/bb/ui/crumbs/hobwidget.py b/bitbake/lib/bb/ui/crumbs/hobwidget.py
> index dba278c..d10c56b 100644
> --- a/bitbake/lib/bb/ui/crumbs/hobwidget.py
> +++ b/bitbake/lib/bb/ui/crumbs/hobwidget.py
> @@ -89,6 +89,7 @@ class hcc:
> "cpio.xz" : ["cpio.xz"],
> "vmdk" : ["vmdk"],
> "cpio.lzma" : ["cpio.lzma"],
> + "elf" : ["elf"],
> }
>
> class HobViewTable (gtk.VBox):
Why do we have a hardcoded list here and why do new image types cause
builds to fail?
We need to rewrite this code so this does not happen and the user at
least gets a sensible error message. Hardcoded lists are bad...
I've merged the patch but I'd like to see a bug opened about this.
Cheers,
Richard
More information about the bitbake-devel
mailing list