[bitbake-devel] [PATCH 2/2] hob2: create a standalone deploy image tool

[Wang, Shane]

> -----Original Message-----
> From: Kang Kai [mailto:kai.kang at windriver.com]
> Sent: Tuesday, June 05, 2012 11:37 AM
> To: dvhart at linux.intel.com
> Cc: Wang, Shane; zhenfeng.zhao at windriver.com;
> bitbake-devel at lists.openembedded.org
> Subject: [PATCH 2/2] hob2: create a standalone deploy image tool
> 
> [Yocto 2388]
> 
> Create a standalone deploy image tool using the existing dialog
> including DeployImageDialog and ImageSelectionDialog.
> 
> Duplicate the gtk and pygtk versions check in the hob.py because this
> will be run separately.
> 
> Update ui/crumbs/utils.py that it needs to 'import bb' when run this
> tool.
> 
> Signed-off-by: Kang Kai <kai.kang at windriver.com>
> ---
>  bitbake/bin/bitbake-deployimage   |  135
> +++++++++++++++++++++++++++++++++++++
>  bitbake/lib/bb/ui/crumbs/utils.py |    1 +
>  2 files changed, 136 insertions(+), 0 deletions(-)
>  create mode 100755 bitbake/bin/bitbake-deployimage
> 
> diff --git a/bitbake/bin/bitbake-deployimage
> b/bitbake/bin/bitbake-deployimage
> new file mode 100755
> index 0000000..8fdd21b
> --- /dev/null
> +++ b/bitbake/bin/bitbake-deployimage
> @@ -0,0 +1,135 @@
> +#!/usr/bin/python
> +
> +
> +requirements = "FATAL: Gtk+ 2.20.0 or higher, PyGtk version 2.22.0 or higher
> and PyGobject are required to use Hob"
Kai, I don't like you have this kind of limitation for GTK and PyGTK.
Hob.py does have because we want special efforts on the visual components. For this simple app,
I don't want you to exclude a lot of users who only have lower versions.



> diff --git a/bitbake/lib/bb/ui/crumbs/utils.py
> b/bitbake/lib/bb/ui/crumbs/utils.py
> index cd01a04..939864f 100644
> --- a/bitbake/lib/bb/ui/crumbs/utils.py
> +++ b/bitbake/lib/bb/ui/crumbs/utils.py
> @@ -22,6 +22,7 @@
>  # bitbake which will allow more flexibility.
> 
>  import os
> +import bb
Why is this needed? I don't see any change you made in utils.py.
Is that to say without this line, the functions in utils.py don't work?

> 
>  def which_terminal():
>      term = bb.utils.which(os.environ["PATH"], "xterm")
> --
> 1.7.5.4