[bitbake-devel] [PATCH 2/3] ui/crumbs/hig.py: simplify subprocess call
Kang Kai
kai.kang at windriver.com
Thu Jun 14 10:10:57 UTC 2012
According to Darren's suggestion, subprocess.call() will wait until the
subprocess complete. So simplify the code, use subprocess.call() to wait
command complete.
Signed-off-by: Kang Kai <kai.kang at windriver.com>
---
bitbake/lib/bb/ui/crumbs/hig.py | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/bitbake/lib/bb/ui/crumbs/hig.py b/bitbake/lib/bb/ui/crumbs/hig.py
index 0c3f56c..b586b6c 100644
--- a/bitbake/lib/bb/ui/crumbs/hig.py
+++ b/bitbake/lib/bb/ui/crumbs/hig.py
@@ -27,6 +27,7 @@ import hashlib
import os
import re
import shlex
+import subprocess
from bb.ui.crumbs.hobcolor import HobColors
from bb.ui.crumbs.hobwidget import hcc, hic, HobViewTable, HobInfoButton, HobButton, HobAltButton, HobIconChecker
from bb.ui.crumbs.progressbar import HobProgressBar
@@ -871,8 +872,7 @@ class DeployImageDialog (CrumbsDialog):
tmpname = os.tmpnam()
cmdline += "\"sudo dd if=" + self.image_path + \
" of=" + combo_item + "; echo $? > " + tmpname + "\""
- deploy_process = bb.process.Popen(shlex.split(cmdline))
- deploy_process.wait()
+ subprocess.call(shlex.split(cmdline))
# if file tmpname not exists, that means there is something wrong with xterm
# user can get the error message from xterm so no more warning need.
--
1.7.5.4
More information about the bitbake-devel
mailing list