[bitbake-devel] [PATCH] fetch2: do not try to checksum a socket

[Bernhard Reutner-Fischer]

>> SRC_URI = "file:///scratch/src/uClibc/;branch=master;protocol=rsync;rebaseable=1

> Ah, this makes more sense now. For what its worth, the "file://" url
> handler will simply strip off everything including and after the ";" so
> all it really sees is "file:///scratch/src/uClibc/" but this works since
> it will just copy that directory whole.
>
> It will then attempt to checksum everything in a file:// url which is
> why it finds the socket and then fails. So your change does point at a
> potentially valid issue. Paul might have a better idea on which level we
> might want to fix this at?
>
>> > What is worrying me a bit is that we shouldn't be calling the checksum
>> > code for git repositories at all. Whilst this fix no doubt avoids the
>> > problem, I'm worried there might be something deeper going on...
>>
>> Could it be that the logic to deduce the fetcher is somehow broken?
>>
>> Indeed, this was failing for me a couple of weeks ago with a similar SRC_URI.
>> Back then i could not use file:///mydir;protocol=git (i.e. create a
>> clone from a clone living on the local filesystem) so had to resort
>> back to protocol=rsync.
>> There was a socket lying around in that directory, a leftover from
>> some testsuite run.
>
> FWIW, the url you want is git:///mydir;protocol=file which should work.

Oh, that's rather surprising!
The format suggested to me that, iff specified, with "protocol=" i can
select the fetcher, regardless of the actual path-spec.
Shouldn't protocol have precedence over any eventual path-implied fetcher?
file:///mydir;protocol=rsync
  rsync -a /mydir S
file:///mydir;protocol=git
  git clone -s file:///mydir S

> As of the patches today, this also works as mirror syntax so you could
> even add this in local.conf as a PREMIRROR and leave the recipe
> pristine.

thanks for the hint, yes, i know. Changing the recipe reminds me that
i have local changes and i can paste it to khem easily.
cheers,