[bitbake-devel] [PATCH 00/32] Hob related fixes
Wang, Shane
shane.wang at intel.com
Fri Mar 2 06:48:14 UTC 2012
Joshua Lock wrote on 2012-03-01:
> One thing I did notice whilst reviewing this series is that there's a
> lot of this anti-pattern in the hob 2 code:
> for i in range(len(mylist)):
> rather than:
> for item in list:
>
> Can we make an effort to tidy those up?
I will check those later. I went through them quickly.
Some of them are because the code refers to the index i.
Otherwise, we would have the code.
i = 0
for item in list:
XXXXX
XXX = i
i += 1
which also looks not perfect. But anyway, I will check all of them later and send another patch for improvement.
If there is no reference to the index, I will replace with your style.
--
Shane
>
> Cheers,
> Joshua
More information about the bitbake-devel
mailing list