[bitbake-devel] [PATCH 04/32] Hob: fixed the issue in the brought-in-by dialog.
Joshua Lock
josh at linux.intel.com
Fri Mar 2 18:02:31 UTC 2012
On 01/03/12 23:22, Wang, Shane wrote:
> Joshua Lock wrote on 2012-03-01:
>> On 29/02/12 06:15, Shane Wang wrote:
>>> When typing any thing in the search entry, the brough-in-by dialog will be
>> shown. That is because we call back "selection-changed" signal to pop up the
>> dialog, which is not correct.
>>> This patch is to fix the problem by using "row-activated" signal.
>>>
>>> Signed-off-by: Liming An<limingx.l.an at intel.com>
>>> Signed-off-by: Shane Wang<shane.wang at intel.com>
>>
>> I point out some incorrect padding below but other than that:
>> Signed-off-by: Joshua Lock<josh at linux.intel.com>
>
> OK, Got it. May I know why padding=6 only conforms to hig?
Of course, but you should really read it though rather than asking me to
quote it for you.
"As a basic rule of thumb, leave space between user interface components
in increments of 6 pixels, going up as the relationship between related
elements becomes more distant."
http://developer.gnome.org/hig-book/3.0/design-window.html.en#window-layout-spacing
I've volunteered to work through Hob and make it more HIG conformant but
the HIG for a platform really is a document you should at least be aware
of when developing for it.
Cheers,
Joshua
--
Joshua Lock
Yocto Project "Johannes factotum"
Intel Open Source Technology Centre
More information about the bitbake-devel
mailing list