[bitbake-devel] [PATCH 5/6] ui/crumbs/builder: remove OK/Cancel buttons on Layer dialog. Use Close.

[Xu, Dongxiao]

On Mon, 2012-03-19 at 17:18 -0700, Joshua Lock wrote:
> Signed-off-by: Joshua Lock <josh at linux.intel.com>
> ---
>  lib/bb/ui/crumbs/builder.py |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/bb/ui/crumbs/builder.py b/lib/bb/ui/crumbs/builder.py
> index 1d255ac..9e85e72 100755
> --- a/lib/bb/ui/crumbs/builder.py
> +++ b/lib/bb/ui/crumbs/builder.py
> @@ -668,8 +668,7 @@ class Builder(gtk.Window):
>                       flags = gtk.DIALOG_MODAL
>                           | gtk.DIALOG_DESTROY_WITH_PARENT
>                           | gtk.DIALOG_NO_SEPARATOR,
> -                     buttons = (gtk.STOCK_CANCEL, gtk.RESPONSE_NO,
> -                                gtk.STOCK_OK, gtk.RESPONSE_YES))
> +                     buttons = (gtk.STOCK_CLOSE, gtk.RESPONSE_YES))

If users did some trial operations, for example deleted some layers, is
it better that we provide a "cancel" button for users to ignore their
changes?

Need comments from Belen and Giulia.

Thanks,
Dongxiao

>          response = dialog.run()
>          if response == gtk.RESPONSE_YES:
>              self.configuration.layers = dialog.layers