[bitbake-devel] [PATCH 02/12] Hob: use HobNotebook to implement a notebook in build details page

[Wang, Shane]

Joshua Lock wrote on 2012-03-20:

> On 16/03/12 08:10, Shane Wang wrote:
>>   class RunningBuildModel (gtk.TreeStore):
>> @@ -40,6 +41,32 @@ class RunningBuildModel (gtk.TreeStore):
>>                                   gobject.TYPE_STRING,
>>                                   gobject.TYPE_INT)
>> +    def config_model_filter(self, model, it):
>> +        msg = model.get(it, self.COL_MESSAGE)[0]
>> +        if msg == None or type(msg) != str:
>> +            return False
>> +        if msg.startswith("\nOE Build Configuration:\n"):
>> +            return True
>> +        return False
> 
> I think I commented on this before, this seems like a heavy way to
> achieve this functionality. Is there not another way we can display the
> Build Configuration to the user without having to filter every message
> emitted?
I am going to submit a bug in bugzilla to address it later, since the series of patches block a lot of patch submissions.

> 
> Further, if we're going to display this information in a separate page
> of the notebook would it not make sense to not show it in the build log
> page?
OK, if you want I can remove it. But I suggest to keep it because of your above comment.
That is the configuration information in Configuration Tab comes from different sources.

--
Shane

> 
> Cheers,
> Joshua