[bitbake-devel] [PATCH 00/17][PULL] Hob: Bunch of bug fixes

[Joshua Lock]

On 21/03/12 05:55, Dongxiao Xu wrote:
> Hi Richard,
>
> This pull request is Hob related bug fixes. Please help to review and pull.
>
> Thanks,
> Dongxiao
>
> The following changes since commit d595960fea0988df9004d927bc2ec3439540dd9c:
>
>    Hob: save CONF_VERSION and LCONF_VERSION into template (2012-03-20 14:39:45 +0000)
>
> are available in the git repository at:
>    git://git.pokylinux.org/poky-contrib dxu4/hob-bugfix
>    http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-bugfix
>
> Dongxiao Xu (14):
>    Hob: Still use initcmd != None as the if judgement
>    Hob: Remove split model in GTK Hob
>    cooker: terminate each process when quitting recipe parsing
>    Hob: change package classes selection GUI
>    Hob: Change template button name from "Template" to "Templates"

These all look fine.

>    command.py: Change parseConfigurationFiles API from async to sync
>    process.py: Increase the timeout value for polling commands
>    Hob: Change parseConfigurationFiles API usage

Can you explain some of the reasoning behind this set of changes? If the 
command truly belongs as an asynchronous one I'm not sure why we need to 
increase the timeout duration specifically for it.

>    Hob: Fix the workaround to get image types
>    Hob: Change recipe selection tab order
>    Hob: Change package selection tab order
>    Hob: Move "Create your own image" to the bottom of image list
>    cooker: add inherit information when generating package tree
>    Hob: Use inherit information to judge if a recipe is image type
>
> Shane Wang (3):
>    Hob: Change window title from HOB to Hob
>    Hob: Change "View Packages" description
>    Hob: Change the titles for recipe view and package view

These also look OK to me.

Cheers,
Joshua
-- 
Joshua '贾詡' Lock
         Yocto Project "Johannes factotum"
         Intel Open Source Technology Centre