[bitbake-devel] bitbake/utils: Convert vercmp_string() to use vercmp internally

Chris Larson clarson at kergoth.com
Fri May 4 14:31:37 UTC 2012


On Fri, May 4, 2012 at 7:03 AM, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
> Having two different version comparision algorithms in bitbake has never seemed
> like a sensible idea. Worryingly, they also return different results to each other.
>
> The vercmp_string API is relatively unused with no users in OE-Core or BitBake
> itself for example. This patch converts it to use vercmp internalls, bringing
> consitency to the comparisions which is easy now we have other recently added
> functions. Yes, this changes behaviour but in this case I'd prefer we were
> consistent than having two different comparisions.
>
> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

This seems sane to me (aside: minor typo: internalls). I recall that
we attempted this once in the past with regular OE and got bitten hard
by the actual users in the metadata, but clearly that's no longer a
concern.

Acked-by: Christopher Larson <chris_larson at mentor.com>
-- 
Christopher Larson




More information about the bitbake-devel mailing list