[bitbake-devel] [PATCH] lib/bb/siggen: use open() rather than the file constructor
Joshua Lock
josh at linux.intel.com
Sat May 12 00:58:57 UTC 2012
The Python documentation states:
"When opening a file, it’s preferable to use open() instead of invoking
the file constructor directly." [1]
Further in Python 3 direct use of the file constructor is no longer
possible.
1. http://docs.python.org/library/functions.html#open
Signed-off-by: Joshua Lock <josh at linux.intel.com>
---
lib/bb/siggen.py | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py
index 8c79b17..ca26919 100644
--- a/lib/bb/siggen.py
+++ b/lib/bb/siggen.py
@@ -201,7 +201,7 @@ class SignatureGeneratorBasic(SignatureGenerator):
for dep in data['runtaskdeps']:
data['runtaskhashes'][dep] = self.taskhash[dep]
- p = pickle.Pickler(file(sigfile, "wb"), -1)
+ p = pickle.Pickler(open(sigfile, "wb"), -1)
p.dump(data)
def dump_sigs(self, dataCache):
@@ -250,9 +250,9 @@ def clean_basepaths(a):
return b
def compare_sigfiles(a, b):
- p1 = pickle.Unpickler(file(a, "rb"))
+ p1 = pickle.Unpickler(open(a, "rb"))
a_data = p1.load()
- p2 = pickle.Unpickler(file(b, "rb"))
+ p2 = pickle.Unpickler(open(b, "rb"))
b_data = p2.load()
def dict_diff(a, b, whitelist=set()):
@@ -331,7 +331,7 @@ def compare_sigfiles(a, b):
print "Hash for dependent task %s changed from %s to %s" % (dep, a[dep], b[dep])
def dump_sigfile(a):
- p1 = pickle.Unpickler(file(a, "rb"))
+ p1 = pickle.Unpickler(open(a, "rb"))
a_data = p1.load()
print "basewhitelist: %s" % (a_data['basewhitelist'])
--
1.7.7.6
More information about the bitbake-devel
mailing list