[bitbake-devel] [PATCH v2] bitbake: Colorize knotty interactive console output

[Chris Larson]

On Sun, Nov 11, 2012 at 8:17 AM, Seth Bollinger <seth.boll at gmail.com> wrote:

> @@ -67,6 +86,8 @@ class BBLogFormatter(logging.Formatter):
>          if record.levelno == self.PLAIN:
>              msg = record.getMessage()
>          else:
> +            if self.color_enabled:
> +                self.colorize(record)
>


I'm not seeing your definition of color_enabled in the constructor.
Wouldn't this attribute not exist when it's first created, before
enable_color() is called? Have you tested this with a non-interactive
terminal? I'd think you'd want a self.color_enabled = False in the
constructor for the formatter.
-- 
Christopher Larson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20121111/1ff40425/attachment-0001.html>