[bitbake-devel] [PATCH v2 1/4] hob: don't show error dialog for errors during building
Paul Eggleton
paul.eggleton at linux.intel.com
Fri Sep 21 14:47:23 UTC 2012
During building we already report errors in a special tab and
indicate when the build has failed; bringing up a dialog was a
regression introduced in bitbake revision
5bab81b124087d63d6eb62a861e1241714fcd483.
Fixes [YOCTO #3151].
Signed-off-by: Paul Eggleton <paul.eggleton at linux.intel.com>
---
bitbake/lib/bb/ui/crumbs/hobeventhandler.py | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
index 8fc1732..49db2de 100644
--- a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
+++ b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
@@ -183,10 +183,11 @@ class HobHandler(gobject.GObject):
self.emit("sanity-failed", event._msg)
elif isinstance(event, logging.LogRecord):
- if event.levelno >= logging.ERROR:
- formatter = bb.msg.BBLogFormatter()
- msg = formatter.format(event)
- self.error_msg += msg + '\n'
+ if not self.building:
+ if event.levelno >= logging.ERROR:
+ formatter = bb.msg.BBLogFormatter()
+ msg = formatter.format(event)
+ self.error_msg += msg + '\n'
elif isinstance(event, bb.event.TargetsTreeGenerated):
self.current_phase = "data generation"
--
1.7.9.5
More information about the bitbake-devel
mailing list