[bitbake-devel] [PATCH] hob: Buttons width and height are taken for host
Paul Eggleton
paul.eggleton at linux.intel.com
Wed Sep 26 09:20:02 UTC 2012
Hi Ioana,
On Tuesday 25 September 2012 12:21:05 Ioana Grigoropol wrote:
> - removed all set_size_request calls for buttons in order to:
> - force autosizing of buttons with regard to the text length
> - use host theme default height for buttons
> - modified buttons on image details page to have the same height (default
> host one) and the width of the button with the largest text - modified Stop
> button on build details page to have the default height by directly
> attaching it to the containing table instead of hbox
>
> Signed-off-by: Ioana Grigoropol <ioanax.grigoropol at intel.com>
> ---
> bitbake/lib/bb/ui/crumbs/builddetailspage.py | 12 +--
> bitbake/lib/bb/ui/crumbs/hig.py | 2 +-
> bitbake/lib/bb/ui/crumbs/imageconfigurationpage.py | 15 +--
> bitbake/lib/bb/ui/crumbs/imagedetailspage.py | 101
> ++++++++++++++++---- bitbake/lib/bb/ui/crumbs/packageselectionpage.py |
> 2 +-
> bitbake/lib/bb/ui/crumbs/recipeselectionpage.py | 2 +-
> 6 files changed, 102 insertions(+), 32 deletions(-)
>
> diff --git a/bitbake/lib/bb/ui/crumbs/builddetailspage.py
> b/bitbake/lib/bb/ui/crumbs/builddetailspage.py index a927c21..5add31d
> 100755
> --- a/bitbake/lib/bb/ui/crumbs/builddetailspage.py
> +++ b/bitbake/lib/bb/ui/crumbs/builddetailspage.py
> @@ -165,7 +165,7 @@ class BuildDetailsPage (HobPage):
> self.builder.handler.build.model.connect_after("row-changed",
> self.scroll_to_present_row, self.scrolled_view_build.get_vadjustment(),
> self.build_tv)
>
> self.button_box = gtk.HBox(False, 6)
> - self.back_button = HobAltButton('<< Back')
> + self.back_button = HobAltButton('<< Back')
I did make this change to avoid a runtime warning due to invalid markup - did
you change it back on purpose? If so I don't see it mentioned in the commit
message.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
More information about the bitbake-devel
mailing list