[bitbake-devel] [PATCH v2 0/6] fetch2: Updated SFTP fetcher

[Richard Purdie]

On Wed, 2013-01-30 at 08:55 +0100, Olof Johansson wrote:
> Hi,
> 
> On 2013-01-29 08:50, Olof Johansson wrote:
> > Olof Johansson (6):
> >   fetch2: Remove unused code in wget fetcher
> >   fetch2: Add a class representing a generic URI
> >   fetch2: unittests for bb.fetch2.URI class
> >   fetch2: Adapt encode/decode url to use URI class
> >   fetch2: Add editor modelines for bb.tests.*
> >   fetch2: Add SFTP fetcher
> 
> One thing I forgot to mention; after speaking with kergoth on IRC
> last Friday, we found that there are some performance penelties
> in using the URI class instead of encode/decodeurl. I tried to
> profile and see if there were any obvious ways to get it down to
> the level of the old encode/decodeurl, but nothing obvious.
> 
> I did the performance evaluation by running the unittests.
> 
> Forking and running the unittests in seperate processes shows no
> change:
> 
>  http://codepad.org/SYsVsckY
> 
> However, running them in a single process with the timeit module
> shows a pretty big (proportional) regression:
> 
>  http://codepad.org/Vzu7Pqqw
> 
> Is this significant? Running the tests 10000, each run creating
> three URI objects, takes ~2 seconds.

In the scheme of things and other bitbake overheads, I'd suspect its not
significant although it is a good thing to check...

What were the other changes between v1 and v2? In cases like this a 0/6
summary email is helpful.

Cheers,

Richard