[bitbake-devel] [PATCH_V2 06/16] hob & bitbake: append a value to a variable from hob throught bitbake

[Paul Eggleton]

On Friday 26 July 2013 14:35:38 Voicu, Cristiana wrote:
> > 1) We should not be expanding ${TOPDIR} using direct string replacement.
> > Do we even need to do this?
> 
> > 2) In any case it appears to be using a hardcoded value instead of val
> > when it calls append_var_in_file()
> 
> I have implemented this way because Hob receives BB_FILES already expanded,
> when it uses getVariable() method.

OK, but if you're going to expand the value you should use bitbake's own means 
of expanding it rather than trying to do so yourself.

> Also I chose to save it hardcoded (using TOPDIR), to be more general in
> local.conf (in case the local.conf is moved)

I agree you'd want ${TOPDIR} unexpanded in the value set in local.conf. 
However, if you pass in a path to the function (which in this case includes 
the ${TOPDIR} reference) surely that's the value you'd save into local.conf 
and not an additional hardcoded value?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre