[bitbake-devel] [PATCH] knotty, xmlrpc: add observer-only mode

[Richard Purdie]

On Thu, 2013-06-13 at 16:23 +0100, Alex Damian wrote:
> On 06/12/2013 02:11 PM, Richard Purdie wrote:
> > On Fri, 2013-06-07 at 16:42 +0100, Alex DAMIAN wrote:
> >> From: Alexandru DAMIAN <alexandru.damian at intel.com>
> >>
> >> I add an observer only mode for the knotty UI and
> >> the XMLRPC server that will allow the UI to register
> >> a callback with a server in order to receive events.
> >>
> >> The observer-UI will not send any commands to the
> >> server apart from registering as an event handler.
> >>
> >> Signed-off-by: Alexandru DAMIAN <alexandru.damian at intel.com>
> >> ---
> >>   bin/bitbake             |  8 +++++++-
> >>   lib/bb/server/xmlrpc.py | 18 ++++++++++++------
> >>   lib/bb/ui/knotty.py     | 29 +++++++++++++++++------------
> >>   lib/bb/ui/uievent.py    |  1 +
> >>   4 files changed, 37 insertions(+), 19 deletions(-)
> >>

You responded to one of my comments but not the other.

To put my concern succinctly, I think even in observer mode the UIs
should still be able to query variables. I do not think they should be
writing to things though, or running any of the async commands. The
whole token business isn't working quite right yet.

My worry is the architecture you're building here isn't quite right, its
limiting the clients unnecessarily and complicating the handover between
clients. I appreciate this patch in itself isn't too problematic,
however if I merge it, you will continue down this path and we will end
up adding code that is problematic. I therefore don't think I can take
this patch until we better figure out what we need to do with the token
handling, I do know we can do better than what is here.

Cheers,

Richard