[bitbake-devel] [PATCH] data.py: Add a warning when expandKeys overwrites an existing key

[Mark Hatle]

When two variables are defined as:

${var} = "bar"
foo = "foobar"

The value of 'foo' when ${var} == foo becomes indeterminate.  We
want to warn a user when this situation has been encountered so they
can take corrective actions.

In the above example usually foo == bar, unless multilibs are enabled.
Then ml-foo = "ml-foobar".

Signed-off-by: Mark Hatle <mark.hatle at windriver.com>
---
 lib/bb/data.py | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/bb/data.py b/lib/bb/data.py
index 7047f48..110666c 100644
--- a/lib/bb/data.py
+++ b/lib/bb/data.py
@@ -158,6 +158,11 @@ def expandKeys(alterdata, readdata = None):
 
     for key in todolist:
         ekey = todolist[key]
+        if ekey in keys(alterdata):
+            val = alterdata.getVar(key, 0)
+            newval = alterdata.getVar(ekey, 0)
+            if val is not None and newval is not None:
+                bb.warn("Variable key %s (%s) replaces original key %s (%s)." % (key, val, ekey, newval))
         alterdata.renameVar(key, ekey)
 
 def inheritFromOS(d, savedenv, permitted):
-- 
1.8.1.2.545.g2f19ada