[bitbake-devel] [PATCH] data/codeparser: Improve handling of contains functions
Chris Larson
clarson at kergoth.com
Tue Nov 26 02:07:06 UTC 2013
On Mon, Nov 25, 2013 at 3:59 PM, Richard Purdie <
richard.purdie at linuxfoundation.org> wrote:
> One of the current frustrations with the sstate checksums is that
> code like base_contains('X', 'y',...) adds a full dependency on X
> and varies depend even on whitespace changes in X.
>
> This patch adds special handling of the contains functions to expand
> the first parameter and check for the flag specified by the second
> parameter (assuming its a string).
>
> The result is then appended to the value of the variable with a "Set"
> or "Unset" status. If the flag is added/removed, the stored variable
> value changes and hence the checksum changes. No dependency on X
> is added so it is free to change with regard to other flags or
> whitespace.
>
> This code is far from ideal, ideally we'd have properly typed variables
> however it fixes a major annoyance of the current checksums and
> is of enough value its worth adding in a stopgap solution. It shouldn't
> significantly restrict any propely typed variable implementation in
> future.
>
> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
>
Looks good, will be very helpful for now.
Signed-off-by: Christopher Larson <chris_larson at mentor.com>
--
Christopher Larson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20131125/35cbe566/attachment-0002.html>
More information about the bitbake-devel
mailing list