[bitbake-devel] [PATCH] HOB: MACHINE should be saved in conf files using ?=

Valentin Popa valentin.popa at intel.com
Fri Oct 4 16:29:58 UTC 2013


On 10/04/2013 04:37 PM, Richard Purdie wrote:
> On Thu, 2013-10-03 at 16:27 +0300, cristiana.voicu wrote:
>> I know I replied with an ack for this patch, but working on a similar
>> bug I realized that replacing the comment "total += "\n#added by
>> bitbake" with total += "\n#added by hob" in bitbake code is not ok. I
>> think it will be better to give as argument the comment string, in order
>> to keep this method reusable in  other ui.
> To make things simpler can someone send a follow up patch to make this a
> parameter please?
>
> Cheers,
>
> Richard
>
In case of multiple UI's in case some of them assigns(or earlyassigns) a 
var then another one wants to do the same thing, which lines do we 
cancel/comment in local.conf ? Do we let configurations from different 
UIs to coexist in local.conf?
(with the respect of the code from cooker.py:
#check if the variable was saved before in the same way
#if true it replace the place where the variable was
declared
#else it comments it

                     if contents[begin_line-1]== "#added by hob\n":
                         contents[begin_line] = "%s %s \"%s\"\n" % (var, 
op, val)
                         replaced = True
                     else:
                         for ii in range(begin_line, end_line):
                             contents[ii] = "#" + contents[ii]
)



More information about the bitbake-devel mailing list