[bitbake-devel] [1.18][PATCH] methodpool: Retire it, remove global method scope

[Richard Purdie]

On Tue, 2013-09-10 at 12:33 -0400, Denys Dmytriyenko wrote:
> From: Richard Purdie <richard.purdie at linuxfoundation.org>
> 
> Having a global method scope confuses users and with the introduction
> of parallel parsing, its not even possible to correctly detect conflicting
> functions. Rather than try and fix that, its simpler to retire the global
> method scope and restrict functions to those locations they're defined
> within. This is more what users actually expect too.
> 
> If we remove the global function scope, the need for methodpool is reduced
> to the point we may as well retire it. There is some small loss of caching
> of parsed functions but timing measurements so the impact to be neglibile
> in the overall parsing time.
> 
> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
> Tested-by: Denys Dmytriyenko <denys at ti.com>

In general I wouldn't take this (as a feature removal) however the code
in question was really broken when we introduced parallel parsing. Its
therefore totally broken, has been for a long time and this patch is
therefore a good thing as it is a bugfix rather than feature removal.

So I've merged it.

Cheers,

Richard