[bitbake-devel] [PATCH 6/8] bitbake: cooker, command: add a command to return global data
Richard Purdie
richard.purdie at linuxfoundation.org
Mon Sep 16 12:21:38 UTC 2013
On Mon, 2013-09-16 at 12:56 +0100, Alex DAMIAN wrote:
> From: Alexandru DAMIAN <alexandru.damian at intel.com>
>
> Adding the 'getDataDump' read-only command that will
> return a dump of the global data state.
>
> This will be used by UI clients to get the build configuration.
>
> Signed-off-by: Alexandru DAMIAN <alexandru.damian at intel.com>
> ---
> bitbake/lib/bb/command.py | 8 ++++++++
> bitbake/lib/bb/cooker.py | 15 +++++++++++++++
> 2 files changed, 23 insertions(+)
>
> diff --git a/bitbake/lib/bb/command.py b/bitbake/lib/bb/command.py
> index f1abaf7..84136f1 100644
> --- a/bitbake/lib/bb/command.py
> +++ b/bitbake/lib/bb/command.py
> @@ -145,6 +145,14 @@ class CommandsSync:
> """
> command.cooker.shutdown(True)
>
> + def getDataDump(self, command, params):
> + """
> + Returns a dump of the global state. Call with
> + variable flags to be retrieved as params.
> + """
> + return command.cooker.getGlobalExpandedData(params)
To be blunt, this *sucks* as an API call. "getDataDump" tells me nothing
about what it does. "getGlobalExpandedData" doesn't do much better.
"getAllKeyFlags"?
and please pass in a list as param[0] so there is a:
flaglist = params[0]
in there. This means we can add other parameters if we ever need to and
we don't have complete lock in to the API.
Cheers,
Richard
More information about the bitbake-devel
mailing list