[bitbake-devel] [PATCH 03/16] siggen: Use lookup cache exclusively
Richard Purdie
richard.purdie at linuxfoundation.org
Mon Sep 16 21:53:20 UTC 2013
All the values we need are already guaranteed to be in the lookupcache
so rather than fetch variables again, just use the cache. This gives a
small performance improvement and simplifies the code.
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
lib/bb/siggen.py | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py
index fb8b678..c15ba28 100644
--- a/lib/bb/siggen.py
+++ b/lib/bb/siggen.py
@@ -91,8 +91,7 @@ class SignatureGeneratorBasic(SignatureGenerator):
basehash = {}
for task in tasklist:
- data = d.getVar(task, False)
- lookupcache[task] = data
+ data = lookupcache[task]
if data is None:
bb.error("Task %s from %s seems to be empty?!" % (task, fn))
@@ -115,16 +114,8 @@ class SignatureGeneratorBasic(SignatureGenerator):
alldeps = sorted(seen)
for dep in alldeps:
data = data + dep
- if dep in lookupcache:
- var = lookupcache[dep]
- elif dep[-1] == ']':
- vf = dep[:-1].split('[')
- var = d.getVarFlag(vf[0], vf[1], False)
- lookupcache[dep] = var
- else:
- var = d.getVar(dep, False)
- lookupcache[dep] = var
- if var:
+ var = lookupcache[dep]
+ if var is not None:
data = data + str(var)
self.basehash[fn + "." + task] = hashlib.md5(data).hexdigest()
taskdeps[task] = alldeps
--
1.8.1.2
More information about the bitbake-devel
mailing list