[bitbake-devel] [PATCH] Fix support for anonymous methods in foobar_%.bbappend files

Chris Larson clarson at kergoth.com
Sat Feb 22 04:14:18 UTC 2014


On Fri, Feb 21, 2014 at 9:46 AM, Jacob Kroon <jacob.kroon at mikrodidakt.se>wrote:

> -            funcname = ("__anon_%s_%s" % (self.lineno,
> self.filename.translate(string.maketrans('/.+-@', '_____'))))
> +            funcname = ("__anon_%s_%s" % (self.lineno,
> self.filename.translate(string.maketrans('/.+-@%', '______'))))
>

I know it's not related to this particular patch, but there's no reason for
us to call string.maketrans() inside of MethodPool.eval(), that should
probably have been a class member, no reason to regenerate the translation
table every time, after all :)
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20140221/d6b19661/attachment-0002.html>


More information about the bitbake-devel mailing list