[bitbake-devel] [PATCH 1/2] bitbake: fetch2/git: Add sanity check for SHA validity of tag

[Richard Purdie]

On Wed, 2014-01-08 at 12:43 +0000, Richard Purdie wrote:
> On Wed, 2014-01-08 at 12:32 +0100, Martin Jansa wrote:
> > > [Luo Zhenhua-B19537] You point is to show warning when SRCREV and tag are set, meanwhile SRCREV is not corresponding to the tag, right?
> > 
> > Yes
> 
> We have several different issues around and the moment and I'm worried
> some cases are going to get lost. We really need a list of them along
> with the planed fix. As I see it we have:
> 
> a) conflicting SRCREV and tag/rev url parameters
> 
> Plan: bb.error on this case asking the user to say what they want
> 
> b) dereferencing of tags when checking existance of commits
> 
> Plan: Add ^{} to ls-remote command to allow dereferencing
> 
> c) tags may get resolved to incorrect tags in sub directories
> 
> Plan: Need to anchor tag/branch search expression
> 
> 
> What else are we missing?
> 
> 
> Ideally we could do with examples of these in the fetcher test code
> too...

FWIW I have fixed the above issues with the patchset that I've sent out
(and is in master-next). Are there any remaining issues?

Cheers,

Richard