[bitbake-devel] can someone explain "git" versus "gitr" wrt PREFERRED_VERSION?

[Paul Eggleton]

Hi Robert,

On Sunday 22 June 2014 08:52:08 Robert P. J. Day wrote:
>   possibly a stupid question but i've never let that stop me before.
> still rummaging around in the bitbake user manual and looking through
> the oe and poky codebase, and i notice examples like this (from poky).
> 
>   first, there's the recipe and PREFERRED_VERSION for drm:
> 
> meta/recipes-graphics/drm/libdrm_git.bb:
>   SRCREV = "e01d68f9f3acfc35fe164283904b5d058c2ab378"
>   PV = "2.4.40+git${SRCPV}"
> 
> meta-yocto/conf/distro/include/poky-floating-revisions.inc:
>   #PREFERRED_VERSION_libdrm ?= "2.4.0+git${SRCREV}"
> 
>   also, the recipe and PFEFERRED_VERSION for libxcb:
> 
> meta/recipes-graphics/xorg-lib/libxcb_git.bb:
>   SRCREV = "625ed596cae6dd8175aeb6cb6f26784928042f22"
>   PV = "1.1.90.1+gitr${SRCPV}"
> 
> meta-yocto/conf/distro/include/poky-floating-revisions.inc:
>   #PREFERRED_VERSION_libxcb ?= "1.1.90.1+gitr${SRCREV}"
> 
> 
>   admittedly, the PREFERRED_VERSION settings for both of those are
> commented out

It's a good job that they are by the way, because a ${SRCREV} reference in 
PREFERRED_VERSION absolutely will not work. (We have % wildcard support in 
PREFERRED_VERSION to handle this situation.) 


> , but why does the first use:
> 
>   git${SRCREV}
> 
> while the second uses:
> 
>   gitr${SRCREV}
> 
> so what's with "git" versus "gitr"? i see no mention of this in the
> bitbake user manual (would that be the right place to explain that?).
> or is that covered in one of the higher-level yocto manuals?

gitr in PV is an old convention. I don't think it really warrants explanation, 
just use the current convention.

>   also (and i realize this is outside the scope of the bitbake
> manual), i noticed the meta-oe layer adds another git-based version
> selector in the gitpkgv.bbclass. is *that* documented anywhere? i
> don't see a single mention of the phrase "gitpkgv" in any of the
> current yocto docs.

Generally the Yocto Project manuals confine themselves to the things that the 
Yocto Project contributes to, and meta-oe isn't one of those things (at least, 
not directly or on a regular basis). So we wouldn't document gitpkgv.bbclass 
there. FWIW, people have asked for that class to be moved to OE-Core but 
Richard would prefer to implement it properly as an extension to the fetcher; 
we still have an enhancement bug open for that if anyone wants to dig into it:

https://bugzilla.yoctoproject.org/show_bug.cgi?id=2872

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre