[bitbake-devel] [PATCH] cooker.py: fix loginfo op being set to an invalid value

Brendan Le Foll brendan.le.foll at intel.com
Wed Nov 12 11:42:39 UTC 2014


loginfo "op" was being set to invalid values in saveConfigurationVar it was
working because set is a python global but append is not. This replaces both
the "op" with strings and removes the crash when calling appendConfigurationVar

Signed-off-by: Brendan Le Foll <brendan.le.foll at intel.com>
---
 lib/bb/cooker.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/bb/cooker.py b/lib/bb/cooker.py
index c6c69c3..087f72f 100644
--- a/lib/bb/cooker.py
+++ b/lib/bb/cooker.py
@@ -240,7 +240,7 @@ class BBCooker:
             f.write(total)
 
         #add to history
-        loginfo = {"op":append, "file":default_file, "line":total.count("\n")}
+        loginfo = {"op":"append", "file":default_file, "line":total.count("\n")}
         self.data.appendVar(var, val, **loginfo)
 
     def saveConfigurationVar(self, var, val, default_file, op):
@@ -309,7 +309,7 @@ class BBCooker:
                 f.write(total)
 
             #add to history
-            loginfo = {"op":set, "file":default_file, "line":total.count("\n")}
+            loginfo = {"op":"set", "file":default_file, "line":total.count("\n")}
             self.data.setVar(var, val, **loginfo)
 
     def removeConfigurationVar(self, var):
-- 
2.1.2




More information about the bitbake-devel mailing list