[bitbake-devel] [PATCH 08/11] toaster: Tiny refinements to the new build button dialog

Alex DAMIAN alexandru.damian at intel.com
Thu Nov 20 16:27:24 UTC 2014


From: Belen Barros Pena <belen.barros.pena at linux.intel.com>

* Get rid of the display:block attribute for the "View
all projects" link, to stop it from firing when you
click outside (but next to) the link

* Give some margin to the incomplete configuration
alert

Signed-off-by: Belen Barros Pena <belen.barros.pena at linux.intel.com>
---
 lib/toaster/toastergui/static/css/default.css | 3 ++-
 lib/toaster/toastergui/templates/base.html    | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/lib/toaster/toastergui/static/css/default.css b/lib/toaster/toastergui/static/css/default.css
index 6194c97..902a2bd 100644
--- a/lib/toaster/toastergui/static/css/default.css
+++ b/lib/toaster/toastergui/static/css/default.css
@@ -133,7 +133,8 @@ select { width: auto; }
 
 /* styles for the new build button */
 .new-build .btn-primary { padding: 4px 30px; }
-#view-all-projects { display: block; }
+.new-build .alert { margin-top: 10px; }
+.new-build .alert p { margin-top: 10px; }
 
 /* Configuration styles */
 .icon-trash { color: #B94A48; font-size: 16px; padding-left: 2px; }
diff --git a/lib/toaster/toastergui/templates/base.html b/lib/toaster/toastergui/templates/base.html
index 87746bf..734d2ad 100644
--- a/lib/toaster/toastergui/templates/base.html
+++ b/lib/toaster/toastergui/templates/base.html
@@ -81,12 +81,12 @@
                         <button id="save-project-button" class="btn" type="button">Save</button>
                         <a href="#" id="cancel-change-project" class="btn btn-link">Cancel</a>
                       </div>
-                      <a id="view-all-projects" href="{% url 'all-projects' %}">View all projects</a>
+                      <p><a id="view-all-projects" href="{% url 'all-projects' %}">View all projects</a></p>
                     </form>
                   </li>
                   <div class="alert" style="display:none">
                     This project's configuration is incomplete,<br/>so you cannot run builds.<br/>
-                    <a href="{% if project.id %}{% url 'project' project.id %}{% endif %}">View project configuration</a>
+                    <p><a href="{% if project.id %}{% url 'project' project.id %}{% endif %}">View project configuration</a></p>
                   </div>
                   <li id="targets-form">
                     <h6>Target(s):</h6>
-- 
1.9.1




More information about the bitbake-devel mailing list