[bitbake-devel] [PATCH 12/12] fetch2/wget.py: latest_versionstring clean improvments minor

Aníbal Limón anibal.limon at linux.intel.com
Fri Nov 28 15:37:19 UTC 2014


Update documentation strings in _check_latest_dir and _check_latest_version
methods with  the correct return types.

_check_latest_version method remove unused testversion variable.

Signed-off-by: Aníbal Limón <anibal.limon at linux.intel.com>
---
 bitbake/lib/bb/fetch2/wget.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/bitbake/lib/bb/fetch2/wget.py b/bitbake/lib/bb/fetch2/wget.py
index 7841553..d82e78c 100644
--- a/bitbake/lib/bb/fetch2/wget.py
+++ b/bitbake/lib/bb/fetch2/wget.py
@@ -192,7 +192,7 @@ class Wget(FetchMethod):
     def _check_latest_dir(self, url, versionstring, ud, d):
         """
         Return the name of the directory with the greatest package version
-        If error or no version, return ""
+        If error or no version, return None
         """
         bb.debug(3, "DirURL: %s, %s" % (url, versionstring))
         soup = BeautifulSoup(self._fetch_index(url, ud, d))
@@ -230,7 +230,7 @@ class Wget(FetchMethod):
     def _check_latest_version(self, url, package, current_version, ud, d):
         """
         Return the latest version of a package inside a given directory path
-        If error or no version, return ""
+        If error or no version, return None
         """
         valid = 0
         version = ('', '', '')
@@ -243,7 +243,6 @@ class Wget(FetchMethod):
 
         pn_regex = d.getVar('REGEX', True)
         if pn_regex:
-            testversion = version
             pn_regex = re.compile(pn_regex)
             bb.debug(3, "pn_regex = '%s'" % (pn_regex.pattern))
             
-- 
1.9.1




More information about the bitbake-devel mailing list