[bitbake-devel] [PATCH] BBHandler: Improve IN_PYTHON_EOF handling

Holger Freyther holger at freyther.de
Sun Dec 20 17:13:51 UTC 2015


> On 20 Dec 2015, at 14:21, Richard Purdie <richard.purdie at linuxfoundation.org> wrote:
> 
> Now we're actively using the line numbers for other thins, having
> magic values like IN_PYTHON_EOF causes problems, in particular, 32
> bit overflow on 32 bit machines.
> 
> There is a neater way to signal eof to feeder(), just using an extra
> parameter so use this instead and drop the IN_PYTHON_EOF magic values.
> 
> This has the added bonus that line numbers are then correct for
> python functions at the end of files.
> 

looks good! thank you for addressing it so quickly!




More information about the bitbake-devel mailing list