[bitbake-devel] [PATCH] depexp.py: Fix segfault if DISPLAY is not set

[Maxin B. John]

Hi,

On Mon, Feb 09, 2015 at 05:20:34AM -0700, Christopher Larson wrote:
> 
> On Mon, Feb 9, 2015 at 4:37 AM, Maxin B. John <maxin.john at enea.com> wrote:
> 
>     +    try:
>     +        gtk.init_check()
>     +    except:
>     +        print "Please set DISPLAY variable before running this command."
>     +        sys.exit(1)
>     +
> 
> 
> It's good that you're fixing this, but 1) this uses the old style non-function
> print, which isn't supported in new python, and 2) it outputs the error message
> to stdout rather than stderr, and 3) it looks like just returning rather than
> exiting is likely the best move.

Thank you very much for the review comments. I will update it as per
your suggestions and send the v2 soon.


> Christopher Larson
> clarson at kergoth dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Maintainer - Tslib
> Senior Software Engineer, Mentor Graphics

Thanks and Regards,
Maxin