[bitbake-devel] [PATCH] fetch2: Remove unecessary code for git submodules

[Christopher Larson]

On Mon, Jul 6, 2015 at 8:13 AM, <eu at felipetonello.com> wrote:

> From: "Felipe F. Tonello" <eu at felipetonello.com>
>
> Only do git submodule update after upack, otherwise the branch and commit
> id
> will be ignored, causing to run git submodules on a wrong ref.
>
> Since .gitmodules file is used to check if there is any submodule, we don't
> need to worry about copying .git/modules directory into the unpacked source
> tree.
>
> Signed-off-by: Felipe F. Tonello <eu at felipetonello.com>
>

We don’t want to be downloading from remote locations in do_unpack, only
do_fetch. This patch will result in the opposite, which means the submodule
sources won’t be included in the git mirror tarball, and it’ll be
impossible to build with BB_NO_NETWORK=1. Also -c fetchall won’t result in
all sources having been fetched, which defeats its purpose.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20150706/22c6cbff/attachment-0002.html>