[bitbake-devel] [PATCH] wget.py: support for semi-colons in URL

[Christopher Larson]

On Mon, Jul 27, 2015 at 9:10 AM, Bystricky, Juro <juro.bystricky at intel.com>
wrote:

> I agree that a generic solution is preferable. I also I think it is only
> prudent to support all valid URLs.
>
> The situation is complicated by the fact that at present it may not be
> possible to determine how to interpret the ‘;’ in SRC_URI.
>
> It can be part of the URL or it can be a SRC_URI delimiter/separator.
>
> As I don’t suppose changing the delimiter character from semi-colon to
> something else (i.e. an unsafe URL character)
>
> is an option, some other changes to the SRC_URI syntax are needed, for
> example:
>
>
>
> 1.       Some form of escape sequence (i.e. ‘;;’ means treat as ‘;’) in
> URL, i.e.
>
> SRC_URI = "
> http://abc123.com/git/?p=gcc/gcc.git;;a=snapshot;;h=a5dd47;downloadfilename=abc.tar
> "
>

This is probably the only sane bet to retain compatibility, at least as far
as I can tell, but perhaps someone else has an idea.

2.       Quoted string implementation, using one of the “unsafe” URL
> characters such as ‘`’, to delimit  the URL
>
> SRC_URI = "’
> http://abc123.com/git/?p=gcc/gcc.git;a=snapshot;h=a5dd47`;downloadfilename=abc.tar
> <http://abc123.com/git/?p=gcc/gcc.git;a=snapshot;h=a5dd47;downloadfilename=abc.tar>
> "
>

Clearly this would be ideal, and is what we should have done, but it’s a
bit late now :) It’s not the only questionable choice we made in the URL
handling back when we wrote the original fetcher (e.g. file:// rather than
file:, but afaik one should only use the former if there’s a netloc/host).
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20150727/cdb84b66/attachment-0002.html>