[bitbake-devel] [PATCH] cooker: Fire BuildCompleted before finishing the command
Richard Purdie
richard.purdie at linuxfoundation.org
Thu Jun 25 16:53:23 UTC 2015
Some handlers hook on BuildComplete so it avoids certain event races
to finish the command after the BuildComplete event is sent out.
This means the UI is available to handle events until the command
completes.
What appears to be a race on one of the sanity tests for event handlers
triggered this change although the failure is hard to reproduce.
[YOCTO #7921]
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py
index d42b389..0dd3296 100644
--- a/bitbake/lib/bb/cooker.py
+++ b/bitbake/lib/bb/cooker.py
@@ -1306,8 +1306,8 @@ class BBCooker:
return False
if not retval:
- self.command.finishAsyncCommand(msg)
bb.event.fire(bb.event.BuildCompleted(len(rq.rqdata.runq_fnid), buildname, item, failures), self.expanded_data)
+ self.command.finishAsyncCommand(msg)
return False
if retval is True:
return True
@@ -1339,8 +1339,8 @@ class BBCooker:
return False
if not retval:
- self.command.finishAsyncCommand(msg)
bb.event.fire(bb.event.BuildCompleted(len(rq.rqdata.runq_fnid), buildname, targets, failures), self.data)
+ self.command.finishAsyncCommand(msg)
return False
if retval is True:
return True
More information about the bitbake-devel
mailing list