[bitbake-devel] [OE-core] [PATCH] bitbake: fetch: Extend subdir unpack parameter to local folder

[Ming Liu]

Hi, Christopher, Richard:

Thanks for the reviewing! And sorry to this delayed feedback, I was on a
vacation.
I had send another patch set which tweaked the code like Christopher
suggested, and added a test case for it.

the best,
thank you

2015-10-05 10:07 GMT+02:00 Richard Purdie <
richard.purdie at linuxfoundation.org>:

> On Sat, 2015-10-03 at 11:35 -0700, Christopher Larson wrote:
> >
> > On Mon, Sep 28, 2015 at 6:11 AM, Ming Liu <liu.ming50 at gmail.com>
> > wrote:
> >         +                    if urldata.parm.get('subdir') != None:
> >         +                        destdir = urldata.parm.get('subdir')
> >         + "/" + destdir
> >
> > If you really care about the difference between None and the empty
> > string, then this should be 'is not None', not '!= None', but most
> > likely you don't, in which case 'if urldata.parm.get('subdir')' is
> > sufficient, and cleaner. Also you do the parm.get() twice, it may be
> > better to store that in a variable.
>
> Chris is correct, this patch needs tweaking. This area of the code also
> keeps seeing various issues so I'd like to ask that we add a test case
> for this in lib/bb/tests/ so we can ensure this doesn't regress in the
> future please.
>
> Cheers,
>
> Richard
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20151113/d67aa0f1/attachment-0002.html>